chore: bump electron to the latest version 33.2.0 (WPB-11996) #8352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
przemvs
reviewed
Nov 15, 2024
electron/src/window/WindowUtil.ts
Outdated
Comment on lines
83
to
85
| if (baseWindow instanceof BrowserWindow) { | ||
| baseWindow.webContents.send(channel, ...args); | ||
| } |
There was a problem hiding this comment.
Maybe will be nice ot add some log if not exist ?
There was a problem hiding this comment.
try catch in there in case the window is undefined or the wrong type?
There was a problem hiding this comment.
No no.. I mean if there will be not !(baseWindow instanceof BrowserWindow) { console.error('baseWindow not exist in BrowserWindow')} or smth like that, because if will not exist will be hard to find issue :)
There was a problem hiding this comment.
what about this? 8ee5b56
przemvs
approved these changes
Nov 15, 2024
aweiss-dev
approved these changes
Nov 15, 2024
|
przemvs
approved these changes
Nov 15, 2024
V-Gira
added a commit
that referenced
this pull request
Nov 15, 2024
* chore: bump electron to 33.2.0 * chore: create helper function to send menu events to web content * runfix: use helper function to address electron api type change * chore: log helper function errors
V-Gira
added a commit
that referenced
this pull request
Nov 15, 2024
chore: bump electron to the latest version 33.2.0 (WPB-11996) (#8352)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to the latest stable version of electron. https://github.com/electron/electron/releases/tag/v33.2.0
List of mjor version changes
Notable breaking change
This change electron/electron#43404 introduced in Electron 33 and backported to 32 and 31 require us to change our system menu click handler as the type of the target window changed from BrowserWindow to BaseWindow